Fix first_samp_timestamp_val property does not work due to missing method in LibraryInterpreter #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lau-yeexuan
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
zhindes
requested changes
Oct 13, 2025
bkeryan
requested changes
Oct 13, 2025
…https://github.com/lau-yeexuan/nidaqmx-python into users/yelau/fix_first_samp_timestamp_val_not_working
lau-yeexuan
force-pushed
the
users/yelau/fix_first_samp_timestamp_val_not_working
branch
from
569cd59 to
2e7655d
Compare
zhindes
approved these changes
Oct 14, 2025
bkeryan
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Exclude GetTimingAttributeTimestamp from interpreter ignored functions. The nidaqmx.Timing.first_samp_timestamp_val now works because LibraryInterpreter contains the get_timing_attribute_timestamp method.
Why should this Pull Request be merged?
Fixes #639
AB#3064756
What testing has been done?
Tests to retrieve first_samp_timestamp_val of simulated 9205.